Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toFastProperties #1636

Merged
merged 5 commits into from
Sep 12, 2020
Merged

Fix toFastProperties #1636

merged 5 commits into from
Sep 12, 2020

Conversation

benjamingr
Copy link
Collaborator

No description provided.

Copy link
Owner

@petkaantonov petkaantonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benjamingr benjamingr merged commit 6c8c069 into master Sep 12, 2020
@benjamingr benjamingr deleted the benjamingr-patch-5 branch September 12, 2020 10:18
@vitaly-t
Copy link
Contributor

Does this fix #1635? Just so, there was no reference provided here, and that issue wasn't updated either.

@benjamingr
Copy link
Collaborator Author

Yes

@iahu
Copy link

iahu commented Dec 20, 2021

hi all, still find eval keyword on toFastProperties, it seems you are not public a new version since year 2019.

please public this PR to NPM, to fix this warning, thanks.

bundles ./src/**/*.ts, !./src/**/*.test.ts, !./src/renderer, !./src/data → dist/esm...
(!) Use of eval is strongly discouraged
https://rollupjs.org/guide/en/#avoiding-eval
../../node_modules/bluebird/js/release/util.js
203:     ic();
204:     return obj;
205:     eval(obj);
         ^
206: }
created dist/esm in 2.7s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants