Skip to content

Commit

Permalink
minor: pleasing cran
Browse files Browse the repository at this point in the history
  • Loading branch information
petermeissner committed Nov 7, 2014
1 parent 37969ad commit fcd5ffd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 19 deletions.
1 change: 0 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ Title: Public Subject Attention via Wikipedia Page Access Statistics
Date: 2014-11-06
Version: 0.2.0
Maintainer: Peter Meissner <[email protected]>
Author: Peter Meissner <[email protected]>
Authors@R: as.person(c(
"Peter Meissner <[email protected]> [aut, cre]",
"R Core team [ctb] (wp_date derived from base package as.Date)"
Expand Down
23 changes: 5 additions & 18 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,6 @@
Since last submission to CRAN:
You requested:

- I changed the last sentence of the package description in DESCRIPTION as requested


Furthermore

- I added R-Core team as contributers because part of the code was derived from R base package
- I changed license to GPL-2 because part of the code was derived from R base package
- What I derived is mentioned in DESCRIPTION as well as within the help files of
wp_date() (the derived generic and its methods)

- I changed default behaviour of the main function to not send any user-agent information along its HTTP requests to comply with cran repository policy

- I extinguished some spelling/grammar errors in the readme

- Travis was used to check package on Ubuntu - ok
- devtools::check() was used to check the package locally on windows machine - ok
- devtools::build() was used to check the package on remote windows machines - ok
- deletion of:
"Author: Peter Meissner <[email protected]>"
from DESCRIPTION because I have an "Authors@R" field already
--> I did as requested

0 comments on commit fcd5ffd

Please sign in to comment.