OTP via Telegram or WhatsApp #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend provides a controller sends OTP codes (from 4 to 8 digits only) via messengers. Telegram and WhatsApp are supported. If they both can't send the OTP to the necessary phone number, SMS will try to be used for sending.
There are new services - general OtpService, which manages gateways, and special TelegramService (interacting with Telegram API) and WhatsAppService (interacting with Telegram API with AuthTempMessages).
New OtpController has lots common code with the MessageController class, so they are refactored and now have common base class.