Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Spinner Loading on Admin Pages #271

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Fix the Spinner Loading on Admin Pages #271

merged 3 commits into from
Nov 25, 2024

Conversation

Mimi-Dang
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Feature
  • Fix
  • Bug Fix
  • Refactor
  • Documentation Update

Related Issues & Documents

Description

This pull request:

  • Fix admin pages where the page gets loaded first without having all the data loaded.
  • removed the spinner in the component wrapper withAdminAuth, so that individual admin pages can load properly with their data without having 2 spinner.

@Mimi-Dang Mimi-Dang added the bug Something isn't working label Nov 25, 2024
@Mimi-Dang Mimi-Dang self-assigned this Nov 25, 2024
peterdanwan
peterdanwan approved these changes Nov 25, 2024
View reviewed changes
Copy link
Owner

@peterdanwan peterdanwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mimi-Dang Mimi-Dang merged commit c0eedc1 into main Nov 25, 2024
1 check passed
@Mimi-Dang Mimi-Dang deleted the Fix-Loading-Issues branch November 25, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdanwan peterdanwan peterdanwan approved these changes

@vinhyan vinhyan Awaiting requested review from vinhyan

@AryanK1511 AryanK1511 Awaiting requested review from AryanK1511

@EvilOlive1 EvilOlive1 Awaiting requested review from EvilOlive1

Assignees

@Mimi-Dang Mimi-Dang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mimi-Dang @peterdanwan