Skip to content

feat: add task delete interface #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 23, 2025
Merged

feat: add task delete interface #14

merged 14 commits into from
Apr 23, 2025

Conversation

gakkiyomi
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 64.86486% with 13 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/whiskerrag_client/space_client.py 50.00% 6 Missing ⚠️
src/whiskerrag_client/task_client.py 37.50% 5 Missing ⚠️
src/whiskerrag_types/model/tenant.py 50.00% 1 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
...rrag_types/interface/db_engine_plugin_interface.py 86.86% <100.00%> (+0.99%) ⬆️
src/whiskerrag_types/model/__init__.py 100.00% <100.00%> (ø)
src/whiskerrag_types/model/knowledge.py 78.83% <100.00%> (+0.11%) ⬆️
src/whiskerrag_types/model/task.py 76.47% <100.00%> (+1.08%) ⬆️
src/whiskerrag_types/model/tenant.py 77.19% <50.00%> (-2.06%) ⬇️
src/whiskerrag_client/task_client.py 45.83% <37.50%> (-4.17%) ⬇️
src/whiskerrag_client/space_client.py 45.83% <50.00%> (-4.17%) ⬇️

@@ -257,6 +257,7 @@ class Knowledge(BaseModel):
file_sha: Optional[str] = Field(None, description="SHA of the file")
file_size: Optional[int] = Field(None, description="size of the file")
metadata: dict = Field({}, description="additional metadata, user can update it")
retrieval_count: int = Field(default=0, description="count of the retrieval")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新增了一个字段,需要去同步修改数据库

Copy link
Contributor

@ch-liuzhide ch-liuzhide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ch-liuzhide ch-liuzhide merged commit 22f3176 into main Apr 23, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants