Doc: add nth-child in the list of pseudo classes for option --exclude-pseudoclasses #222
Conversation
…our as the command line
premailer/premailer.py
Outdated
| @@ -140,7 +140,7 @@ def __init__( | |||
| disable_link_rewrites=False, | |||
| preserve_internal_links=False, | |||
| preserve_inline_attachments=True, | |||
| exclude_pseudoclasses=True, | |||
| exclude_pseudoclasses=False, | |||
There was a problem hiding this comment.
This makes me nervous. Most people use premailer programmatically rather that the __main__.py endpoint. A change here is expected to break the tests. (At the time of writing I'm waiting for Travis to finish) And potentially it might change peoples implementations when they upgrade to the next version.
Which is right I'm not sure about but I'm sure we should have the same defaults in __main__, this file and in the README.
|
Seems @coveralls is broken. "Coverage remained the same at ?% when " |
|
So finally, only the doc changed to avoid to break something. |
| @@ -155,7 +155,7 @@ module. | |||
| --remove-internal-links PRESERVE_INTERNAL_LINKS | |||
| Remove links that start with a '#' like anchors. | |||
| --exclude-pseudoclasses | |||
| Pseudo classes like p:last-child', p:first-child, etc | |||
| Pseudo classes like p:last-child', p:first-child, :nth-child, etc | |||
There was a problem hiding this comment.
Can you make this change in __main__.py too? Line ~53.
There was a problem hiding this comment.
I already did it.
|
You know what sucks? With |
|
Or we could store_false instead but that means that we must rename the option and so... break something, somewhere |
|
Wait! What am I saying! If you use |
|
oops. |
|
For now, can you just make that one last extra edit to the README (about |
calixteman
changed the title
No description provided.