Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidekiq cops to help it serializable params. #77

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Add sidekiq cops to help it serializable params. #77

merged 8 commits into from
Jun 14, 2024

Conversation

ericproulx
Copy link
Contributor

This PR adds 4 new cops to help with Sidekiq's serializable params.

  • ConstArgument
  • DateTimeArgument
  • KeywordArgument
  • SymbolArgument

See cops good/bad

@Bhacaz Bhacaz self-requested a review February 5, 2024 16:50
Bhacaz
Bhacaz reviewed Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@Bhacaz Bhacaz left a comment •
edited by ericproulx
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changelog
  • Faudrait peut-être ajouter de les matcher < ApplicationWorker pour savoir si on est dans une class Worker

@ericproulx
Copy link
Contributor Author

@Bhacaz J'ai ajouté la gestion du ApplicationWorker. Je vais tester sur mon poste.

@ericproulx ericproulx requested a review from Bhacaz June 14, 2024 12:29
@Bhacaz Bhacaz merged commit a4708a9 into main Jun 14, 2024
1 check passed
@Bhacaz Bhacaz deleted the add_sidekiq_cops branch June 14, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bhacaz Bhacaz Bhacaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericproulx @Bhacaz