Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit 3 / lesson 5 ported to F# #246

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

Youenn-Bouglouan
Copy link

And this is the last one :)!

Uses version 1.2.0 of Akka.FSharp.
I had to change pattern matching a bit in the githubCommanderActor so it can match against ReceiveTimeout messages too:

let! message = mailbox.Receive ()
match box message with
| :? ReceiveTimeout as timeout -> // handle ReceiveTimeout messages
| :? GithubActorMessage as githubMessage -> // handle other messages as before
// rest of the code...

The rest is unchanged.

@Youenn-Bouglouan
Copy link
Author

@Aaronontheweb once Lesson 3 / 4 / 5 get merged I'll have 2 more smaller PRs coming:

  1. Move / rename a few folders in Unit 1 and Unit 3 so it follows the same structure as the C# bootcamp
  2. Fix all the dead links to the docs

And that should be all for the F# bootcamp.

@Aaronontheweb
Copy link
Member

Sounds good @Youenn-Bouglouan ! Excellent work. We should also link to the FSharp version from the readme file too. You've done an amazing job.

@Aaronontheweb Aaronontheweb merged commit 7a6a19e into petabridge:FSharp Oct 2, 2017
@Youenn-Bouglouan
Copy link
Author

Thanks @Aaronontheweb it was fun to do! I just submitted #247 that fixes the remaining stuff.

Almost forgot about the link to the F# version, thanks for pointing that out. Will submit a new PR to the C# branch in a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants