Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary download #2

Merged
merged 11 commits into from
Nov 8, 2023
Merged

Binary download #2

merged 11 commits into from
Nov 8, 2023

Conversation

nahime0
Copy link
Collaborator

@nahime0 nahime0 commented Nov 7, 2023

This PR will introduce:

  • An abstraction on the Binary class, to allow new binaries in the future
  • The download of the K6 binary upon the first usage

@nahime0 nahime0 requested a review from nunomaduro November 7, 2023 23:15
@nunomaduro nunomaduro merged commit 1e4ed17 into 2.x Nov 8, 2023
0 of 36 checks passed
@nunomaduro
Copy link
Member

Perfect. I've made some code changes.

@nunomaduro nunomaduro deleted the binary-download branch November 8, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro Awaiting requested review from nunomaduro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahime0 @nunomaduro