Merge pull request #6 from pestphp/3-windows-support

3 windows support
pestphp · Nov 8, 2023 · 4c45536 · 4c45536
2 parents 1e4ed17 + b2d17ba
commit 4c45536
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -7,7 +7,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest] # windows-latest is not supported
+        os: [ubuntu-latest, macos-latest, windows-latest]
         php: ['8.2', '8.3']
         dependency-version: [prefer-lowest, prefer-stable]
         parallel: ['', '--parallel']

diff --git a/src/K6.php b/src/K6.php
@@ -131,10 +131,14 @@ private static function extractZip(string $fileName): void
     }
 
     /**
-     * Returns the computer's architecture.
+     * Returns the computer's architecture. Force amd64 on windows
      */
     private static function arch(): string
     {
+        if(self::os() === 'windows') {
+            return 'amd64';
+        }
+
         return str_contains(php_uname('m'), 'arm') ? 'arm64' : 'amd64';
     }
 

diff --git a/tests/Unit/K6.php b/tests/Unit/K6.php
@@ -19,3 +19,11 @@
 
     expect((string) $binary)->toBe(realpath(__DIR__.'/../../bin/k6-'.k6::K6_VERSION.'-linux-'.$arch.'/k6'));
 })->skipOnMac()->skipOnWindows();
+
+it('infers the path from the environment on Windows', function (): void {
+    $binary = K6::make();
+
+    $arch = 'amd64'; // Always amd64 on windows
+
+    expect((string) $binary)->toBe(realpath(__DIR__.'/../../bin/k6-'.k6::K6_VERSION.'-windows-'.$arch.'/k6.exe'));
+})->skipOnMac()->skipOnLinux();