feat(expectations): support Carbon in toBe
#45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabio-ivona
approved these changes
Jul 10, 2023
owenvoke
approved these changes
Jul 10, 2023
|
Hey @nunomaduro, any chance to merge this? 😄 |
|
No plans for this, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request intercepts Pest's
toBeto add support forCarbon.When adding some tests, I was surprised to see that
expect($date1)->toBe($date2)did not work. This is actually normal, as objects are checked by reference.However, I think testing for date equality is something that's done frequently enough to warrant special handling in the Laravel plugin.