Skip to content

Commit

Permalink
Merge pull request #5 from ijpatricio/feat/consistent-method-name
Browse files Browse the repository at this point in the history
Consistent method name. Git ignore .temp folder.
  • Loading branch information
nunomaduro authored Feb 14, 2025
2 parents bf66a0f + 96e15fe commit 677c5f9
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ coverage.xml
*.swp
*.swo
.phpunit.cache

.temp
# Playwright
node_modules/
/test-results/
Expand Down
Empty file removed .temp/e2e/.gitkeep
Empty file.
6 changes: 0 additions & 6 deletions .temp/e2e/runtime.spec.js

This file was deleted.

6 changes: 3 additions & 3 deletions src/PendingTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ public function toHaveTitle(string $title): self
}

/**
* Build the test result.
* Compile the JavaScript test file.
*/
public function build(): void
public function compile(): void
{
$compiler = new Compiler($this->operations);

Check failure on line 42 in src/PendingTest.php

View workflow job for this annotation

GitHub Actions / Static Tests (prefer-lowest)

Parameter #1 $operations of class Pest\Browser\Compiler constructor expects array<int, Pest\Browser\Contracts\Operation>, array given.

Check failure on line 42 in src/PendingTest.php

View workflow job for this annotation

GitHub Actions / Static Tests (prefer-stable)

Parameter #1 $operations of class Pest\Browser\Compiler constructor expects array<int, Pest\Browser\Contracts\Operation>, array given.

Expand All @@ -55,6 +55,6 @@ public function build(): void
*/
public function __destruct()
{
$this->build();
$this->compile();
}
}

0 comments on commit 677c5f9

Please sign in to comment.