Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage of namespace selection using wildcards v2 #16

Open
wants to merge 6 commits into
base: 3.x
Choose a base branch
from
Open

Allow usage of namespace selection using wildcards v2 #16

wants to merge 6 commits into from

Conversation

naxvog
Copy link
Contributor

@naxvog naxvog commented Sep 30, 2024 •
edited
Loading

See #12

Fixed the stan errors that resulted in the revert (https://github.com/pestphp/pest-plugin-arch/actions/runs/11094754954/job/30822574150)

edit:

  • added pipeline runs for commit prior to the revert

@naxvog naxvog mentioned this pull request Sep 30, 2024
Merged
@nunomaduro
Copy link
Member

Can you add a test like arch()->expect('*')->toUseStrictTypes();, and make that test pass?

@nunomaduro nunomaduro marked this pull request as draft September 30, 2024 10:08
@naxvog
Copy link
Contributor Author

naxvog commented Sep 30, 2024

Added the strict types test

Output using the only method:
image

@naxvog naxvog marked this pull request as ready for review October 1, 2024 20:31
@naxvog
Copy link
Contributor Author

naxvog commented Oct 1, 2024

Added #17 to fix those PR checks

@jambonfarci
Copy link

@nunomaduro Does this PR need #17 to move forward ? 🙏

@naxvog
Copy link
Contributor Author

naxvog commented Nov 5, 2024

I am considering forking and republishing on packagist in order to allow others to use this.

Will be a commitment to keep this up to date though ;)

@naxvog
Copy link
Contributor Author

naxvog commented Nov 12, 2024

Haven't had time to test it properly but it should work:
https://github.com/naxvog/pest-plugin-arch
https://packagist.org/packages/naxvog/pest-plugin-arch

composer require --dev naxvog/pest-plugin-arch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naxvog @nunomaduro @jambonfarci