Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: executeTrade not possible due to payment_option set to 1 (default) if not specified #64

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Fix: executeTrade not possible due to payment_option set to 1 (default) if not specified #64

merged 2 commits into from
Aug 3, 2024

Commits on Aug 3, 2024

  1. added a payment_option field in the executeTrade method and changed t… 

    …he default to payment_option=2 (due to the fact that the default value of bitcoin.de side is set to 1, however an payment_option value of 1 is not possible as bitcoin.de removed the express trading option since the fidor bank shut down.) To allow other payment_options as well the param can be overwritten.
    @floshodan
    floshodan committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    404d0d8 View commit details
    Browse the repository at this point in the history

  2. added payment_option field to unit test executeTrade

    @floshodan
    floshodan committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    647e6b2 View commit details
    Browse the repository at this point in the history