lazy_class config added #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd make sense to have the default be |
|
I'd also open a clean commit with a better name and explaining the rational before submitting as a PR to lazyload: Add config option for adding a class to lazy imagesWe wanted to be able to target images using a selector that are marked with lazy. This commit introduce a configuration option called "lazy_css_class" that if set will be added to all image with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay I finally got this working.
I could add another config option to prevent the class from being added in the first place, and then if it is, there is a default class that can be altered with this first config option. What do you think?