Refactor build system and update to current dependencies. #3
Conversation
|
It renders a bit differently on Linux/Firefox with a few extensions (privacy badger and ublock) than the existing one. E.g. I don't see the rotating logos or the vimeo video. Also, the margins are wider and the font is smaller. |
|
I'm not able to reproduce issues specific to your browser extensions. Screenshot showing working logos and video, on my local Firefox:
Minor layout changes are expected. We defer to Bootstrap for nearly all style details; as I said before, this PR includes a major Bootstrap version bump. If there's something specific you'd like me to change, please provide details. |
|
My issue with missing things was due to the EFF privacybadger browser extension blocking personaltelco.net presumably because it was coming from quinn.tk. It's not blocked from the personaltelco site, so that's not something we need to worry about going forward. I think the primary changes I'd make is to make some things bigger. Your version renders (in firefox on ubuntu) substantially smaller than Ben's. The carousel thing on Bens spans the page, yours has margins. Those are the things I've noticed and I don't think are improvements. Otherwise, functionally it looks like it's working equivalently. |
Splash page updates!
This PR builds on Ben's work from a few years back. It swaps out Grunt/Dust for Webpack, and updates to the latest versions of all dependencies, including jQuery (which resolves the security issues with this repository), and Bootstrap (which necessitates some layout changes, these are included).
All of the features included the previous iteration are retained.
ptp-apiandptp-splash-serverintegration are unchanged.FOOCAB.pltemplate replacement has been tested and works exactly the same as before.Demo of the new version can be seen here:
https://quinn.tk/~keegan/splash/splash.html?node=Keegan
Original demo, for comparison:
https://personaltelco.net/splashdemo/splash.html?node=Keegan
Any and all feedback is welcome.
Thanks!