Skip to content

Implemented dummy SegmentFromPoint, Integrated into web app #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2023

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented May 8, 2023

Describe this pull request. Link to relevant GitHub issues, if any.

In service of #27 .

This PR implements a dummy SegmentFromPoint RSO2 action that takes in a user-specified point and returns 3 contender masks that contain that point. It also integrates this into the BiteSelection page, by letting the user click an arbitrary point, displaying the masks as buttons, and letting them select a mask to move on.

Explain how this pull request was tested, including but not limited to the below checkmarks.

I first tested the dummy action, ensuring that:

  • In normal usage, it gives feedback as expected and then returns three masks.
  • It cancels additional goals that come in while it is currently processing a goal.
  • A goal can be canceled.
  • Once it has finished a goal, it accepts the next goal.

I then tested its integration with the web app, by:

  • Ensuring that a user can click a point on the image, it will call the action, display masks around that point, and clicking each button sets the corresponding mask to global state before moving on.
  • Ensuring that if the user clicks multiple points, it doesn't register multiple callbacks.
  • Ensuring that when the page is refreshed the action is canceled and action client is destroyed.
  • Ensuring that when we change states the action client is destroyed.

Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • [N/A, Issue Make the App Fully Responsive #9 ] Thoroughly test your code's responsiveness by rendering it on different devices, browsers, etc.
  • [N/A, doesn't change the user flow] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati requested a review from taylorkf May 8, 2023 01:12
@amalnanavati amalnanavati force-pushed the amaln/ros2_dummy_face_detection branch from 1a9bc5c to 8df79a9 Compare May 8, 2023 01:20
@amalnanavati amalnanavati force-pushed the amaln/ros2_dummy_food_segmentation branch from 9d97a7b to 9b4cbd9 Compare May 8, 2023 01:22
@amalnanavati
Copy link
Contributor Author

amalnanavati commented May 9, 2023

Render the point the user clicked on as a reminder

EDIT: I spun off a new issue, #46 , for this.

@amalnanavati amalnanavati force-pushed the amaln/ros2_dummy_food_segmentation branch from 9b4cbd9 to d407e39 Compare May 10, 2023 08:24
@amalnanavati amalnanavati force-pushed the amaln/ros2_dummy_face_detection branch from b173099 to 84cf8f2 Compare May 12, 2023 02:48
Base automatically changed from amaln/ros2_dummy_face_detection to main May 12, 2023 02:51
@amalnanavati amalnanavati force-pushed the amaln/ros2_dummy_food_segmentation branch 2 times, most recently from 328a44f to 670634f Compare May 12, 2023 03:13
@amalnanavati amalnanavati force-pushed the amaln/ros2_dummy_food_segmentation branch from 670634f to 31b0c75 Compare May 12, 2023 03:18
@amalnanavati amalnanavati merged commit ad0f2dc into main May 12, 2023
@amalnanavati amalnanavati deleted the amaln/ros2_dummy_food_segmentation branch May 12, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants