Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an optional flag,
save_trajectory_viz
, inMoveTo
that saves a PNG and CSV of the trajectory before executing it.Testing procedure
Launch all the necessary nodes as documented in the README.
/MoveAbovePlate
) and verify that it succeeds.move_to.py
to setsave_trajectory_viz: bool = True,
and re-run the action. Look in theshare
folder forada_feeding
within your workspace'sinstall
dir. Verify that the PNG and CSV of the trajectory was saved.Future TODOs
If we end up using this visualization often, we should enable passing a
debug
flag viakwargs
to eachMoveTo
tree and turn thesave_trajectory_viz
flag on based on that. That way, this flag can be turned on via config files, and won't require modifying source files. However, since we only envision using this visualization for one specific issue (#98 ), we are currently merging the code in where the only way to enable this flag is modifying source.Before opening a pull request
python3 -m black .
ada_feeding
directory, run:pylint --recursive=y --rcfile=.pylintrc .
.Before Merging
Squash & Merge