Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement visualizing trajectories #99

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Sep 19, 2023

Description

This PR implements an optional flag, save_trajectory_viz, in MoveTo that saves a PNG and CSV of the trajectory before executing it.

Testing procedure

Launch all the necessary nodes as documented in the README.

  • Run an action (e.g., /MoveAbovePlate) and verify that it succeeds.
  • Manually modify move_to.py to set save_trajectory_viz: bool = True, and re-run the action. Look in the share folder for ada_feeding within your workspace's install dir. Verify that the PNG and CSV of the trajectory was saved.

Future TODOs

If we end up using this visualization often, we should enable passing a debug flag via kwargs to each MoveTo tree and turn the save_trajectory_viz flag on based on that. That way, this flag can be turned on via config files, and won't require modifying source files. However, since we only envision using this visualization for one specific issue (#98 ), we are currently merging the code in where the only way to enable this flag is modifying source.

Before opening a pull request

  • Format your code using black formatter python3 -m black .
  • Run your code through pylint and address all warnings/errors. The only warnings that are acceptable to not address is TODOs that should be addressed in a future PR. From the top-level ada_feeding directory, run: pylint --recursive=y --rcfile=.pylintrc ..

Before Merging

  • Squash & Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant