Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate bundle and catalog, add release command #28

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

jgbernalp
Copy link
Contributor

This PR creates the missing bundle dockerfile to build a bundle. It also adds a release command that builds and deploys the bundle and catalog

@jgbernalp jgbernalp force-pushed the generate-bundle-and-update-version branch from 43a65c0 to 23fe7fb Compare November 28, 2024 17:25
@jgbernalp jgbernalp force-pushed the generate-bundle-and-update-version branch from 23fe7fb to b4e4a9c Compare November 28, 2024 17:37
@Nexucis
Copy link
Member

Nexucis commented Nov 29, 2024

Overall it looks fine, I just don't understand what we have to publish.(certainly because I am not familiar with the release and deployment workflow of the operator)

Do we need to publish also a docker image containing the operator binary (a.k.a build thanks to main.go) ?
Or actually it's not necessary and we just need to publish the bundle image ?
Or do we need to publish both ?

Asking that because if we only need to publish the bundle image, I can imagining we don't need goreleaser anymore to be able to build docker manifest for arm64 and amd64

Signed-off-by: Gabriel Bernal <[email protected]>
@jgbernalp jgbernalp force-pushed the generate-bundle-and-update-version branch from 6fa4839 to b1643c3 Compare December 2, 2024 08:33
Signed-off-by: Gabriel Bernal <[email protected]>
@jgbernalp
Copy link
Contributor Author

We need 3 images:

  • perses-operator: Image with the operator binary, we can use the go releaser as we need multi-arch support.
  • bundle: Image with metadata. Contains Perses CRDs, other operator metadata and configuration. It references the perses-operator image, in this case: docker.io/persesdev/[email protected]. These are not architecture specific images, but describe that the perses-operator binary supports multiple archs
  • catalog: Image with metadata. Can reference multiple bundles, in this case references the perses bundle: docker.io/persesdev/[email protected]. I will add a specific catalog image dockerfile in another PR, for now is using a default generated image.

Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks for the explanations @jgbernalp it's clearer now !

labels:
operatorframework.io/arch.amd64: supported
operatorframework.io/arch.arm64: supported
operatorframework.io/arch.ppc64le: supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the moment, only amd64 and arm64 are supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok will adjust.

Signed-off-by: Gabriel Bernal <[email protected]>
@jgbernalp jgbernalp force-pushed the generate-bundle-and-update-version branch 2 times, most recently from 4e309d5 to d5547f8 Compare December 2, 2024 10:50
Signed-off-by: Gabriel Bernal <[email protected]>
@jgbernalp jgbernalp force-pushed the generate-bundle-and-update-version branch from d5547f8 to c228977 Compare December 2, 2024 10:52
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Nexucis Nexucis merged commit bf1f3b5 into main Dec 2, 2024
5 checks passed
@Nexucis Nexucis deleted the generate-bundle-and-update-version branch December 2, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants