-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate bundle and catalog, add release command #28
Conversation
43a65c0
to
23fe7fb
Compare
Signed-off-by: Gabriel Bernal <[email protected]>
23fe7fb
to
b4e4a9c
Compare
Overall it looks fine, I just don't understand what we have to publish.(certainly because I am not familiar with the release and deployment workflow of the operator) Do we need to publish also a docker image containing the operator binary (a.k.a build thanks to Asking that because if we only need to publish the |
Signed-off-by: Gabriel Bernal <[email protected]>
6fa4839
to
b1643c3
Compare
Signed-off-by: Gabriel Bernal <[email protected]>
We need 3 images:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool thanks for the explanations @jgbernalp it's clearer now !
labels: | ||
operatorframework.io/arch.amd64: supported | ||
operatorframework.io/arch.arm64: supported | ||
operatorframework.io/arch.ppc64le: supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the moment, only amd64
and arm64
are supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will adjust.
Signed-off-by: Gabriel Bernal <[email protected]>
4e309d5
to
d5547f8
Compare
Signed-off-by: Gabriel Bernal <[email protected]>
d5547f8
to
c228977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR creates the missing bundle dockerfile to build a bundle. It also adds a release command that builds and deploys the bundle and catalog