[ENHANCEMENT] efficient deepcopy

Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>

api/v1alpha1/perses_config.go

@@ -1,20 +1,25 @@
 package v1alpha1
 
 import (
-	"github.com/barkimedes/go-deepcopy"
+	"fmt"
+
+	"github.com/brunoga/deep"
 	"github.com/perses/perses/pkg/model/api/config"
 )
 
 type PersesConfig struct {
 	config.Config `json:",inline"`
 }
 
-func (in *PersesConfig) DeepCopyInto(out *PersesConfig) {
-	temp, err := deepcopy.Anything(in)
-
-	if err != nil {
-		panic(err)
-	}
 
-	*out = *(temp.(*PersesConfig))
+func (in *PersesConfig) DeepCopyInto(out *PersesConfig) {
+    if in == nil {
+        return
+    }
+
+    copied, err := deep.Copy(in)
+    if err != nil {
+        panic(fmt.Errorf("failed to deep copy PersesConfig: %w", err))
+    }   
+    *out = *copied
 }

api/v1alpha1/perses_dashboard.go

@@ -1,23 +1,28 @@
 package v1alpha1
 
 import (
-	"encoding/json"
+	"fmt"
 
+	"github.com/brunoga/deep"
 	persesv1 "github.com/perses/perses/pkg/model/api/v1"
 )
 
 type Dashboard struct {
 	persesv1.DashboardSpec `json:",inline"`
 }
 
-// DeepCopyInto is a manually implemented deep copy function and this is required because:
-// 1. The embedded persesv1.DashboardSpec from the Perses project doesn't implement DeepCopyInto
-// 2. controller-gen can't automatically generate DeepCopy methods for types it doesn't own
+
+
 func (in *Dashboard) DeepCopyInto(out *Dashboard) {
-	*out = *in
-	// Create a deep copy of the embedded DashboardSpec
-	outSpec := persesv1.DashboardSpec{}
-	bytes, _ := json.Marshal(in.DashboardSpec)
-	_ = json.Unmarshal(bytes, &outSpec)
-	out.DashboardSpec = outSpec
+    if in == nil {
+        return
+    }
+
+    copied, err := deep.Copy(in)
+    if err != nil {
+        panic(fmt.Errorf("failed to deep copy Dashboard: %w", err))
+    }   
+    *out = *copied
 }
+
+

api/v1alpha1/perses_datasource.go

@@ -1,7 +1,9 @@
 package v1alpha1
 
 import (
-	"github.com/barkimedes/go-deepcopy"
+	"fmt"
+
+	"github.com/brunoga/deep"
 	persesv1 "github.com/perses/perses/pkg/model/api/v1"
 )
 
@@ -10,11 +12,13 @@ type Datasource struct {
 }
 
 func (in *Datasource) DeepCopyInto(out *Datasource) {
-	temp, err := deepcopy.Anything(in)
-
-	if err != nil {
-		panic(err)
-	}
-
-	*out = *(temp.(*Datasource))
+    if in == nil {
+        return
+    }
+
+    copied, err := deep.Copy(in)
+    if err != nil {
+        panic(fmt.Errorf("failed to deep copy Datasource: %w", err))
+    }   
+    *out = *copied
 }

go.mod

@@ -20,6 +20,7 @@ require (
 
 require (
 	github.com/beorn7/perks v1.0.1 // indirect
+	github.com/brunoga/deep v1.2.4 // indirect
 	github.com/cespare/xxhash/v2 v2.3.0 // indirect
 	github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
 	github.com/emicklei/go-restful/v3 v3.12.1 // indirect

go.sum

@@ -2,6 +2,8 @@ github.com/barkimedes/go-deepcopy v0.0.0-20220514131651-17c30cfc62df h1:GSoSVRLo
 github.com/barkimedes/go-deepcopy v0.0.0-20220514131651-17c30cfc62df/go.mod h1:hiVxq5OP2bUGBRNS3Z/bt/reCLFNbdcST6gISi1fiOM=
 github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
 github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
+github.com/brunoga/deep v1.2.4 h1:Aj9E9oUbE+ccbyh35VC/NHlzzjfIVU69BXu2mt2LmL8=
+github.com/brunoga/deep v1.2.4/go.mod h1:GDV6dnXqn80ezsLSZ5Wlv1PdKAWAO4L5PnKYtv2dgaI=
 github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=
 github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

internal/perses/common/perses_client_factory.go

@@ -60,7 +60,7 @@ func (f *PersesClientFactoryWithURL) CreateClient(config persesv1alpha1.Perses)
 		return nil, err
 	}
 	restClient, err := clientConfig.NewRESTClient(clientConfig.RestConfigClient{
-		URL: &common.URL{URL: parsedURL.URL},
+		URL: parsedURL,
 	})
 
 	if err != nil {