Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add helm chart test #42

Merged
merged 5 commits into from
Dec 11, 2024
Merged

[FEATURE] Add helm chart test #42

merged 5 commits into from
Dec 11, 2024

Conversation

ibakshay
Copy link
Contributor

This pull request fixes #39

@ibakshay
[FEATURE] add helm chart test 🔥
b2751f2 
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
@ibakshay
[IGNORE] bump helm chart version to 0.7.4
8bb0d11 
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
@ibakshay
[DOCS] update readme
d7b5f16 
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
@ibakshay
[IGNORE] review comment fixes
3cc01c3 
Signed-off-by: Akshay Iyyadurai Balasundaram <[email protected]>
@ibakshay
Copy link
Contributor Author

Now, the helm chart testing will run directly in the Pull Request CI :)

Screenshot of the GitHub Action workflow logs

image

@ibakshay ibakshay mentioned this pull request Dec 10, 2024
Closed
@nicolastakashi
Copy link
Contributor

Amazing work @ibakshay !
I'm wondering if we should add one test for ingress as well and maybe another one for dashboard sync sidecar, but it can be on another PR.

celian-garcia
celian-garcia requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@celian-garcia celian-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of questions as I'm discovering the framework.
The only thing I'm not in favour of is to put enabled: true by default. I'd say this would be enabled only in test platforms and IMO with helm we should respect the "default is production" paradigm. (I don't know if it exists I just invented it haha)

charts/perses/values.yaml Show resolved Hide resolved
charts/perses/templates/tests/test-config.yaml Show resolved Hide resolved
charts/perses/templates/tests/test-config.yaml Show resolved Hide resolved
charts/perses/templates/tests/test.yaml Show resolved Hide resolved
@ibakshay ibakshay mentioned this pull request Dec 11, 2024
Merged
@ibakshay
Copy link
Contributor Author

Amazing work @ibakshay ! I'm wondering if we should add one test for ingress as well and maybe another one for dashboard sync sidecar, but it can be on another PR.

My pleasure. @nicolastakashi. Added a test for ingress in this commit fabd571. I am not sure how to test for dashboard sync sidecar container. I will tackle it in another PR and with some other improvements if required :)

celian-garcia
celian-garcia approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@celian-garcia celian-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your very detailed answers. LGTM then 🚀

@nicolastakashi nicolastakashi merged commit fb68bb5 into perses:main Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celian-garcia celian-garcia celian-garcia approved these changes

@nicolastakashi nicolastakashi nicolastakashi approved these changes

@Nexucis Nexucis Awaiting requested review from Nexucis Nexucis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Helm Chart Tests using bats-detik framework
3 participants
@ibakshay @nicolastakashi @celian-garcia