Update nikic/php-parser from ^4 to ^5 #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More recent versions of phpunit require version 5 of php-parser for coverage reporting and other mechanisms within the phpunit framework. As a result the current version of ^4 conflicts with phpunit ^11.
This commit updates the minimum required PHP version from 7.3 to 7.4 following updates in php-parser in version 5, this will make this a breaking change for those on impacted php versions.
On MacOS the
tempnam()
method call prepends a "private/" to the virtual file location and caused unlinking issues to occur, I have gotten around this by checking if the path string contains rather than matching directly.nikic/php-parser no longer supports
ParserFactory::create()
calls and I have changed this to the new recommended::createForHostVersion()
method for continued support inline with the oldParserFactory::PREFER_PHP7
approach.Following the updates some of the unit test snapshots now contain slightly modified outputs which when verified I have updated accordingly.