Extract SourceGraph from PeripheryKit #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rofle100lvl
force-pushed
the
ExtractedSourceGraph
branch
from
de62cce to
2971145
Compare
rofle100lvl
force-pushed
the
ExtractedSourceGraph
branch
from
2971145 to
a36de5c
Compare
rofle100lvl
commented
Jun 24, 2024
ileitch
requested changes
Jun 30, 2024
ileitch
approved these changes
Jul 3, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to extract SourceGraph from PeripheryKit in separate module.
The reason why I want to do it is - it's easier to maintain the project, think about public API, when you have a lot of well divided modules. And in my opinion SourceGraph is well separated from other ones