-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bcm283x: Issue 62 Change bcm283x to use ioctl for GPIO pins, not sysfs. #63
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
+ Coverage 26.8% 27.4% +0.5%
=======================================
Files 92 96 +4
Lines 11548 11774 +226
=======================================
+ Hits 3097 3221 +124
- Misses 8316 8418 +102
Partials 135 135 ☔ View full report in Codecov by Sentry. |
@maruel can you give me an idea of how to fix this? periph.io/x/host/v3/bcm283xError: bcm283x/gpio.go:199:22: undefined: gpioioctl.GPIOLine |
NM, I see the problem. gpioioctl doesn't exist for Windows/MacOS, and that's messing with it. |
The stance periph.io takes is that the code is compilable on all platforms so users can read the documentation, e.g. in VSCode while on Windows but functionality that do not make sense (e.g. bcm238x on Windows) is okay to not work. |
Thanks! |
This fixes Edge detection does not work on Raspbian Bookworm #62
It changes the bcm283x/gpio.go to use gpioioctl rather than sysfs.
With this patch, obtaining GPIO pins via:
now work as expected.