Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SearchOptions class #363

Merged
merged 6 commits into from
Nov 4, 2020
Merged

Add SearchOptions class #363

merged 6 commits into from
Nov 4, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Oct 26, 2020

This adds default values and validation to searcher->getAll options.

Co-incidence is that this fixes #369

refs:

@glensc glensc self-assigned this Oct 26, 2020
@glensc glensc force-pushed the default-page-options branch 2 times, most recently from f9ddcbe to 5565f76 Compare October 26, 2020 22:04
@glensc glensc force-pushed the default-page-options branch 2 times, most recently from 2ff336d to 7422c92 Compare October 30, 2020 14:20
@glensc glensc force-pushed the default-page-options branch from 7422c92 to d30892c Compare October 30, 2020 14:44
@glensc glensc marked this pull request as ready for review October 30, 2020 14:49
@glensc glensc force-pushed the default-page-options branch from d30892c to 5953864 Compare October 30, 2020 17:48
@glensc glensc mentioned this pull request Nov 4, 2020
@glensc
Copy link
Contributor Author

glensc commented Nov 4, 2020

Merging, as confirmed to be ok by @Mte90: #369 (comment)

@glensc glensc merged commit 1e2bdc4 into master Nov 4, 2020
@glensc glensc deleted the default-page-options branch November 4, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined index: page
1 participant