Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some php-cs-fixer rules #330

Merged
merged 9 commits into from
Sep 19, 2020
Merged

Apply some php-cs-fixer rules #330

merged 9 commits into from
Sep 19, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Sep 19, 2020

Applies some useful php-cs-fixer fixers.

This is not enforced, as no CI integration and there's some fighting to do with Sickler-CI.

refs: #299

@glensc glensc self-assigned this Sep 19, 2020
Multi-line function call not indented correctly; expected 12 spaces but found 8
Line indented incorrectly; expected at least 12 spaces, found 8
@glensc glensc merged commit 12d6d55 into master Sep 19, 2020
@glensc glensc deleted the php-cs-fixer branch September 19, 2020 09:13
@lauripiisang
Copy link
Contributor

lauripiisang commented Sep 22, 2020

Why not add the related .php_cs config + dev dependency so contributors could keep using/applying these rules?

@glensc
Copy link
Contributor Author

glensc commented Sep 22, 2020

@lauripiisang I don't have a sane explanation :)

@glensc glensc mentioned this pull request Oct 12, 2020
@glensc
Copy link
Contributor Author

glensc commented Oct 12, 2020

Committing config, and applying more rules from @psr2 group:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants