Skip to content

Commit

Permalink
debian/pcp.postinst.tail: don't dink with /var/run/pcp here
Browse files Browse the repository at this point in the history
Addresses https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071103
where /var/run/pcp may not exist at the time we tried to chown+chmod
it here.

The setup up of /var/run/pcp is more safely done in pcp-reboot-init,
but there was a small change required to
    src/pcp-reboot-init/pcp-reboot-init.service.in
required to make sure this was run before pmcd was started.
  • Loading branch information
kmcdonell committed Dec 8, 2024
1 parent 3883cf8 commit f9dfda6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions debian/pcp.postinst.tail
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ chown pcp:pcp /var/lib/pcp/tmp
chmod 775 /var/lib/pcp/tmp
chown pcp:pcp /var/log/pcp
chmod 775 /var/log/pcp
chown pcp:pcp /var/run/pcp
chmod 775 /var/run/pcp
# we used to dink with /var/run/pcp here, but that is done more
# safely in pcp-reboot-init now

# must match src/pmdas/{json,bash,mmv}/GNUmakefile
#
Expand Down
2 changes: 1 addition & 1 deletion src/pcp-reboot-init/pcp-reboot-init.service.in
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Description=PCP Reboot Initialization Helper Service
Documentation=man:pcp-reboot-init(1)
DefaultDependencies=no
After=network-online.target systemd-tmpfiles-setup.service
Before=pmlogger.service pmie.service pmproxy.service
Before=pmlogger.service pmie.service pmproxy.service pmcd.service

[Service]
Type=oneshot
Expand Down

0 comments on commit f9dfda6

Please sign in to comment.