pmlogconf: move perfevent metrics for atop into own file

Lukas came across a pmlogger warning on a machine without the perfevent PMDA installed - need to make the atop configs for this configured at runtime for enabling by zeroconf.
performancecopilot · Feb 26, 2019 · eefcff8 · eefcff8
1 parent 2d90115
commit eefcff8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/pmlogconf/tools/atop b/src/pmlogconf/tools/atop
@@ -42,8 +42,6 @@ probe	kernel.uname.sysname ~ Linux ? include : exclude
 	kernel.percpu.cpu.guest
 
 	hinv.cpu.clock
-	perfevent.hwcounters.INSTRUCTIONS_RETIRED.value
-	perfevent.hwcounters.UNHALTED_REFERENCE_CYCLES.value
 
 	mem.vmstat.pgscan_direct_dma
 	mem.vmstat.pgscan_direct_dma32

diff --git a/src/pmlogconf/tools/atop-perfevent b/src/pmlogconf/tools/atop-perfevent
@@ -0,0 +1,6 @@
+#pmlogconf-setup 2.0
+ident   perfevent metrics sampled by the atop command
+probe	perfevent.active values ? include : exclude
+
+	perfevent.hwcounters.INSTRUCTIONS_RETIRED.value
+	perfevent.hwcounters.UNHALTED_REFERENCE_CYCLES.value
diff --git a/src/pmlogconf/tools/localdefs b/src/pmlogconf/tools/localdefs
@@ -4,6 +4,7 @@ FILES = \
 	atop-summary \
 	atop-httpstats \
 	atop-nfsclient \
+	atop-perfevent \
 	atop-hotproc \
 	atop-gpustats \
 	atop-infiniband \