PMM-13553 Revert the upgrade of kong #3319
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3319 +/- ##
==========================================
+ Coverage 43.51% 43.53% +0.02%
==========================================
Files 366 366
Lines 44169 44169
==========================================
+ Hits 19219 19231 +12
+ Misses 23265 23252 -13
- Partials 1685 1686 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ademidoff
requested review from
BupycHuk,
idoqo and
JiriCtvrtka
and removed request for
a team
| - name: Disable grafana | ||
| ini_file: | ||
| path: /etc/supervisord.d/grafana.ini | ||
| section: program:grafana | ||
| option: autostart | ||
| value: "false" |
There was a problem hiding this comment.
let's enable it after initialization
There was a problem hiding this comment.
That seems to be redundant, since pmm-managed generates grafana.ini anyway. Therefore, it will get enabled before we know it. :)
There was a problem hiding this comment.
it will slowdown first initialization and we will loose time that we win by running initialization during build time
There was a problem hiding this comment.
Btw, the block above is not even necessary given the current initial grafana.ini config.
There was a problem hiding this comment.
Moreover, setting autostart:true does not do anything on its own - the service will not restart without supervisord, which either needs to restart or to reread the config.
PMM-13533
Link to the Feature Build: SUBMODULES-3771
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: