PMM-7 Pull ova box from s3 instead of vagrant cloud. #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talhabinrizwan
requested review from
BupycHuk,
idoqo and
ademidoff
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3210 +/- ##
==========================================
- Coverage 43.40% 43.38% -0.03%
==========================================
Files 399 399
Lines 41698 41698
==========================================
- Hits 18101 18089 -12
- Misses 21581 21593 +12
Partials 2016 2016
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
reviewed
Sep 24, 2024
Co-authored-by: Alex Demidoff <[email protected]>
BupycHuk
approved these changes
Sep 24, 2024
ademidoff
approved these changes
Sep 24, 2024
talhabinrizwan
added a commit
that referenced
this pull request
Sep 24, 2024
* PMM-7 Pull ova box from s3 instead of vagrant cloud. * Update build/Makefile Co-authored-by: Alex Demidoff <[email protected]> --------- Co-authored-by: Alex Demidoff <[email protected]>
talhabinrizwan
added a commit
that referenced
this pull request
Sep 24, 2024
* PMM-7 Pull ova box from s3 instead of vagrant cloud. * Update build/Makefile --------- Co-authored-by: Alex Demidoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13385
Link to the Feature Build: SUBMODULES-0