Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13132 Encryption rotation. #3199

Open
wants to merge 62 commits into
base: PMM-13129-encryption
Choose a base branch
from

Conversation

JiriCtvrtka
Copy link
Contributor

@JiriCtvrtka JiriCtvrtka commented Sep 12, 2024

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 46.06742% with 96 lines in your changes missing coverage. Please review.

Project coverage is 44.76%. Comparing base (751c084) to head (6539cbf).

Files with missing lines Patch % Lines
managed/cmd/pmm-encryption-rotation/main.go 0.00% 39 Missing ⚠️
managed/services/encryption/encryption_rotation.go 50.72% 21 Missing and 13 partials ⚠️
managed/utils/encryption/encryption.go 58.53% 11 Missing and 6 partials ⚠️
managed/models/database.go 82.60% 0 Missing and 4 partials ⚠️
managed/utils/encryption/helpers.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           PMM-13129-encryption    #3199      +/-   ##
========================================================
+ Coverage                 44.70%   44.76%   +0.05%     
========================================================
  Files                       360      362       +2     
  Lines                     36143    36262     +119     
========================================================
+ Hits                      16158    16231      +73     
- Misses                    18322    18347      +25     
- Partials                   1663     1684      +21     
Flag Coverage Δ
admin 11.47% <ø> (-0.06%) ⬇️
agent 52.81% <ø> (ø)
managed 46.91% <46.06%> (+0.08%) ⬆️
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@percona percona deleted a comment from percona-robot Sep 19, 2024
@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review September 19, 2024 14:57
@JiriCtvrtka JiriCtvrtka requested review from a team as code owners September 19, 2024 14:57
@JiriCtvrtka JiriCtvrtka requested review from ademidoff, BupycHuk and idoqo and removed request for a team September 19, 2024 14:57
encryption-rotation/main.go Outdated Show resolved Hide resolved
encryption-rotation/main.go Outdated Show resolved Hide resolved
managed/models/database.go Outdated Show resolved Hide resolved
managed/models/database.go Outdated Show resolved Hide resolved
managed/models/database.go Outdated Show resolved Hide resolved
managed/models/database.go Show resolved Hide resolved
managed/models/settings_helpers.go Outdated Show resolved Hide resolved
managed/utils/encryption/helpers.go Outdated Show resolved Hide resolved
managed/utils/encryption/helpers.go Outdated Show resolved Hide resolved
managed/utils/encryption/encryption.go Outdated Show resolved Hide resolved
managed/models/encryption_rotation.go Outdated Show resolved Hide resolved
managed/models/encryption_rotation.go Outdated Show resolved Hide resolved
managed/models/encryption_rotation.go Outdated Show resolved Hide resolved
managed/models/encryption_rotation.go Outdated Show resolved Hide resolved
managed/models/encryption_rotation.go Outdated Show resolved Hide resolved
managed/models/encryption_rotation.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants