Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to buf schema v2 and move api related tasks to dedicated Makefile #3176

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

artemgavrilov
Copy link
Contributor

@artemgavrilov artemgavrilov commented Aug 23, 2024

PMM-7

Link to the Feature Build: SUBMODULES-0

This PR migrates buf configuration to v2. It allowed to move all api related tasks to dedicated Makefile.

P.S. I was trying to find a way to use some plugins only for part of the modules, but unfortunately it's not possible for now.

https://buf.build/docs/migration-guides/migrate-v2-config-files

Same for PMM v3: #3178

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.34%. Comparing base (01b41df) to head (65a0497).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3176      +/-   ##
==========================================
+ Coverage   43.32%   43.34%   +0.02%     
==========================================
  Files         399      399              
  Lines       41654    41654              
==========================================
+ Hits        18046    18056      +10     
+ Misses      21590    21580      -10     
  Partials     2018     2018              
Flag Coverage Δ
admin 11.61% <ø> (-0.06%) ⬇️
agent 52.88% <ø> (+0.13%) ⬆️
managed 44.39% <ø> (ø)
vmproxy 66.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artemgavrilov artemgavrilov marked this pull request as ready for review August 23, 2024 14:42
@artemgavrilov artemgavrilov requested review from a team and BupycHuk as code owners August 23, 2024 14:42
@artemgavrilov artemgavrilov requested review from ademidoff, idoqo and JiriCtvrtka and removed request for a team August 23, 2024 14:42
@artemgavrilov artemgavrilov changed the title Migrate to buf schema v2 and reorganize api package Migrate to buf schema v2 and move api related tasks to dedicated Makefile Aug 23, 2024
Copy link
Member

@ademidoff ademidoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, but I'm wondering if it is really worth to contribute such a change to v2 versus v3?

After we release 2.43.0, the whole team should completely switch their focus to getting v3 out the door.

Makefile.include Outdated Show resolved Hide resolved
@artemgavrilov
Copy link
Contributor Author

Great stuff, but I'm wondering if it is really worth to contribute such a change to v2 versus v3?

After we release 2.43.0, the whole team should completely switch their focus to getting v3 out the door.

I can provide same changes for v3 as well, or just for v3.

@ademidoff
Copy link
Member

ademidoff commented Aug 26, 2024

Great stuff, but I'm wondering if it is really worth to contribute such a change to v2 versus v3?
After we release 2.43.0, the whole team should completely switch their focus to getting v3 out the door.

I can provide same changes for v3 as well, or just for v3.

OK, there is seemingly no harm for v2, so let's do both :)

Thanks for contributing, bro!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants