PMM-13077 list change log for PMM server version #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #3045 +/- ##
==========================================
+ Coverage 44.50% 44.51% +0.01%
==========================================
Files 357 357
Lines 35594 35670 +76
==========================================
+ Hits 15842 15880 +38
- Misses 18129 18163 +34
- Partials 1623 1627 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idoqo
requested review from
ademidoff and
JiriCtvrtka
and removed request for
a team
idoqo
force-pushed
the
PMM-13077-list-pmm-server-versions
branch
from
3cd5397
to
6cc2711
Compare
idoqo
changed the title
This adds support for PMM release notes by fetching the correct markdown files from github. It also includes fixes for api tests by accepting v3 prefixes in versions.
idoqo
force-pushed
the
PMM-13077-list-pmm-server-versions
branch
from
639c9c1
to
fa1c630
Compare
idoqo
commented
Jul 24, 2024
| assert.Equal(t, "3.0.1", versions[2].Version.String()) | ||
| assert.Equal(t, "3.1.0", versions[3].Version.String()) | ||
| }) | ||
|
|
||
| t.Run("TestLatest", func(t *testing.T) { | ||
| version.Version = "2.41.0" |
There was a problem hiding this comment.
This test will fail for now since the changes to version service have not been deployed.
ademidoff
force-pushed
the
v3
branch
3 times, most recently
from
8421bc2
to
da25a0c
Compare
BupycHuk
approved these changes
Aug 7, 2024
JiriCtvrtka
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13077
Link to the Feature Build: SUBMODULES-0
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: