Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12375 add database version to services #2438

Closed
wants to merge 42 commits into from
Closed

PMM-12375 add database version to services #2438

wants to merge 42 commits into from

Conversation

ademidoff
Copy link
Member

PMM-12375

Link to the Feature Build: SUBMODULES-0

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@codecov
Copy link

codecov bot commented Aug 25, 2023 •
edited
Loading

Codecov Report

Merging #2438 (c89d862) into main (576142a) will decrease coverage by 0.14%.
The diff coverage is 1.14%.

@@            Coverage Diff             @@
##             main    #2438      +/-   ##
==========================================
- Coverage   42.86%   42.72%   -0.14%     
==========================================
  Files         384      385       +1     
  Lines       48245    48353     +108     
==========================================
- Hits        20681    20660      -21     
- Misses      25620    25754     +134     
+ Partials     1944     1939       -5
Flag Coverage Δ
admin 10.41% <ø> (-0.05%) ⬇️
vmproxy 69.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
admin/commands/management/add.go 70.96% <ø> (ø)
agent/commands/run.go 0.00% <0.00%> (ø)
agent/connectionchecker/connection_checker.go 53.22% <ø> (+0.70%) ⬆️
agent/serviceinfobroker/service_info_broker.go 0.00% <0.00%> (ø)
managed/cmd/pmm-managed/main.go 0.00% <ø> (ø)
managed/models/database.go 42.91% <ø> (ø)
managed/models/service_model.go 82.69% <ø> (ø)
managed/models/service_model_reform.go 95.55% <ø> (-0.28%) ⬇️
managed/services/agents/channel/channel.go 57.40% <ø> (ø)
managed/services/agents/connection_checker.go 0.00% <ø> (ø)
... and 7 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ademidoff
ademidoff commented Aug 25, 2023
View reviewed changes
managed/services/backup/pitr_timerange_service.go
@@ -251,7 +251,7 @@ func getTimelines(slices []*oplogChunk) []Timeline {
var timelines []Timeline
var prevEnd primitive.Timestamp
for _, s := range slices {
if prevEnd.T != 0 && primitive.CompareTimestamp(prevEnd, s.StartTS) == -1 {
if prevEnd.T != 0 && prevEnd.Compare(s.StartTS) == -1 {
Copy link
Member Author

@ademidoff ademidoff Aug 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a deprecation warning.

ademidoff
ademidoff commented Aug 28, 2023
View reviewed changes
.golangci.yml
@@ -104,6 +104,8 @@ linters:
- nlreturn # too annoying
- nosnakecase # deprecated
- scopelint # too many false positives
- structcheck # replaced by unused
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will silence the linter's deprecation warnings.

Alex Tymchuk and others added 3 commits August 28, 2023 10:07
PMM-12375 revert Makefile
296d5cf 
fix: rds_test since one more zone was added by AWS

fix: disable deprecated checks

fix: rds_test since one more zone was added by AWS
@dependabot
Bump github.com/prometheus/alertmanager from 0.25.0 to 0.26.0 (#2436)
57ec9aa 
* Bump github.com/prometheus/alertmanager from 0.25.0 to 0.26.0

Bumps [github.com/prometheus/alertmanager](https://github.com/prometheus/alertmanager) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/prometheus/alertmanager/releases)
- [Changelog](https://github.com/prometheus/alertmanager/blob/main/CHANGELOG.md)
- [Commits](prometheus/alertmanager@v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/alertmanager
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: the FromGlobs parameters

* fix: rds_test since one more zone has been added by AWS

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Tymchuk <[email protected]>
PMM-12375 add a column to store the version
c45cc58
@ademidoff ademidoff force-pushed the PMM-12375-add-database-version-to-services branch from 676d977 to c45cc58 Compare August 28, 2023 10:08
@ademidoff ademidoff force-pushed the PMM-12375-add-database-version-to-services branch from 968b3e6 to 9d1ebec Compare August 30, 2023 09:27
@ademidoff ademidoff force-pushed the PMM-12375-add-database-version-to-services branch from 0727506 to d8f36f4 Compare August 31, 2023 09:27
@ademidoff ademidoff force-pushed the PMM-12375-add-database-version-to-services branch from cb1b200 to bf43ffb Compare September 12, 2023 10:21
Alex Tymchuk and others added 17 commits September 16, 2023 05:40
PMM-12375 add a dedicated message
5de5333
PMM-12375 refactor to use a separate method for version and tableCount
ebfbb9c
@dependabot
Bump github.com/grafana/grafana-api-golang-client from 0.23.0 to 0.24…
f3bf65c 
….0 (#2477)

Bumps [github.com/grafana/grafana-api-golang-client](https://github.com/grafana/grafana-api-golang-client) from 0.23.0 to 0.24.0.
- [Release notes](https://github.com/grafana/grafana-api-golang-client/releases)
- [Commits](grafana/grafana-api-golang-client@v0.23.0...v0.24.0)

---
updated-dependencies:
- dependency-name: github.com/grafana/grafana-api-golang-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
PMM-12375 re-generate protobufs
18806c9
@dependabot @JiriCtvrtka
Bump @typescript-eslint/parser from 6.6.0 to 6.7.0 in /cli-tests (#2476)
8a7b12f 
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.6.0 to 6.7.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.0/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jiří Čtvrtka <[email protected]>
@dependabot
Bump @typescript-eslint/eslint-plugin from 6.6.0 to 6.7.0 in /cli-tes…
3163ec5 
…ts (#2475)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.6.0 to 6.7.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump docker/login-action from 2 to 3 (#2480)
800d582 
Bumps [docker/login-action](https://github.com/docker/login-action) from 2 to 3.
- [Release notes](https://github.com/docker/login-action/releases)
- [Commits](docker/login-action@v2...v3)

---
updated-dependencies:
- dependency-name: docker/login-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump docker/setup-buildx-action from 2 to 3 (#2479)
f2b8b95 
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v2...v3)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@matejkubinec
PMM-11670 Set the cluster label if empty (#2459)
fe495cc 
* PMM-11670 make sure cluster label is not empty

* PMM-11670 fix tests in managed/models

* PMM-11670 fix inventory tests

* PMM-11670 fix tests in managed/qan

* PMM-11670 fix tests in managed/services/victoriametrics

* PMM-11670 fix API tests

* PMM-11670 update API tests

* PMM-11670 remove the deprecated parameter

* PMM-11670 beautify the debug print

---------

Co-authored-by: Matej Kubinec <[email protected]>
@artemgavrilov
PMM-12376 single inventory add endpoint (#2422)
8008009 
* PMM-12376 add a single NodeAdd endpoint

* PMM-12376 add a couple tests for AddNode

* PMM-12376 add more tests

* PMM-12376 remove debug lines

* PMM-12376 format the code

* PMM-12376 address linter errors

* PMM-12376 pass context to transactions

* PMM-12376 add more tests

* PMM-12376 clean up the tests

* PMM-12376 improve the tests

* PMM-12376 re-generate the specs

* PMM-12376 add AddNode to grpc server

* PMM-12376 update the APi documentation

* PMM-12376 update the documentation

* PMM-12376 prefer oneof vs optional

* PMM-12376 update the docs

* PMM-12376 add API tests

* PMM-12376 fix formatting

* PMM-12376 fix API nodes_test

* PMM-12376 fix API tests

* PMM-12376 reindex message props in nodes.proto

Co-authored-by: Artem Gavrilov <[email protected]>

* PMM-12376 use NotEmpty for checking an array

Co-authored-by: Artem Gavrilov <[email protected]>

* PMM-12376 move back the api-tests/server tests

* PMM-12376 running make gen

* PMM-12376 replace NotZerof with NotEmptyf

* PMM-12376 fix the TestContainerNode/Basic API test

---------

Co-authored-by: Artem Gavrilov <[email protected]>
@artemgavrilov
PMM-12448 Fix bug (#2437)
3e453b1 
PMM-12375 trigger the build
@dependabot
Bump docker/build-push-action from 4 to 5 (#2481)
002fdbb 
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4 to 5.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v4...v5)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

PMM-12375 run format

PMM-12375 add message to channel.go

PMM-12375 revert changes made to connectionchecker
PMM-12457 add node_name to agent metrics (#2474)
0697b04 
* PMM-12457 add node_name to agent metrics

* PMM-12457 update the template to use node_name

* PMM-12457 fix punctuation
PMM-12488 update VictoriaMetrics to v1.93.4 (#2483)
b2e10bc
@talhabinrizwan
PMM-9769 update all components (#2478)
0b52509 
* PMM-9769 Use ansible-core instead of ansible package.
* PMM-9769 Update all components.

PMM-12375 re-generate protobufs, fix tests
PMM-12375 add version prop to ProxySQL service
06d99a8 
PMM-12375 move infoRequest to serviceInfoBroker
PMM-12375 move GetInfoFromService to serviceInfoBroker
f1a259a
@ademidoff ademidoff force-pushed the PMM-12375-add-database-version-to-services branch from 69ce63f to f1a259a Compare September 16, 2023 05:43
github-actions[bot]
github-actions bot reviewed Sep 16, 2023
View reviewed changes
agent/serviceinfobroker/service_info_broker.go Outdated Show resolved Hide resolved
agent/serviceinfobroker/service_info_broker.go Outdated Show resolved Hide resolved
agent/serviceinfobroker/service_info_broker.go Outdated Show resolved Hide resolved
@ademidoff
Copy link
Member Author

Close in favor of #2487

@ademidoff ademidoff closed this Sep 16, 2023
@ademidoff ademidoff deleted the PMM-12375-add-database-version-to-services branch September 16, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@BupycHuk BupycHuk Awaiting requested review from BupycHuk BupycHuk will be requested when the pull request is marked ready for review BupycHuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ademidoff @artemgavrilov @talhabinrizwan