-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-4817 move git tags script to pmm #2376
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2376 +/- ##
==========================================
+ Coverage 42.78% 42.81% +0.03%
==========================================
Files 385 385
Lines 48157 48157
==========================================
+ Hits 20602 20620 +18
+ Misses 25615 25597 -18
Partials 1940 1940
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
340c880
to
3ce6898
Compare
@artemgavrilov The codecov check is disrupting the flow. Can we do something about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think if we write the code in Go instead of Bash, we don't have enough Bash experts in our team to maintain it
I have an idea, but it's based on non-GA feature in go. In general root of the problem that we run agent tests multiple times on different DB versions and generate one report. So last run wins, because of that we have this flip-flop coverage for agent. In recent go versions were added binary format for coverage reports, and there is a command that can merge multiple reports into one. But for unit tests binary format is not GA option yet. |
Do you think we can use this feature for the tests? |
I created ticket for that: https://jira.percona.com/browse/PMM-12365 |
* PMM-4817 move create-tags script to pmm * PMM-4817 update the notes * PMM-4817 add more comments * PMM-4817 add popd before continue * PMM-4817 use pmm-submodules vs distinct repos * PMM-4817 clone a specific branch, not main * PMM-4817 update the description * PMM-4817 do not delete the directory if it exists * PMM-4817 popd on push failure
* PMM-4817 move create-tags script to pmm * PMM-4817 update the notes * PMM-4817 add more comments * PMM-4817 add popd before continue * PMM-4817 use pmm-submodules vs distinct repos * PMM-4817 clone a specific branch, not main * PMM-4817 update the description * PMM-4817 do not delete the directory if it exists * PMM-4817 popd on push failure
PMM-4817
Note: please review the linked PR as well.