Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-4817 move git tags script to pmm #2376

Merged
merged 13 commits into from
Aug 9, 2023

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Jul 19, 2023

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2376 (ed1bd43) into main (1b80abb) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
+ Coverage   42.78%   42.81%   +0.03%     
==========================================
  Files         385      385              
  Lines       48157    48157              
==========================================
+ Hits        20602    20620      +18     
+ Misses      25615    25597      -18     
  Partials     1940     1940              
Flag Coverage Δ
admin 10.45% <ø> (+0.04%) ⬆️
agent 52.66% <ø> (+0.12%) ⬆️
managed 44.03% <ø> (+<0.01%) ⬆️
vmproxy 69.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ademidoff ademidoff marked this pull request as ready for review July 20, 2023 08:30
@ademidoff ademidoff requested a review from a team as a code owner July 20, 2023 08:30
@ademidoff ademidoff requested review from idoqo and artemgavrilov and removed request for a team July 20, 2023 08:30
@ademidoff ademidoff force-pushed the PMM-4817-move-git-tags-script-to-pmm branch from 340c880 to 3ce6898 Compare July 20, 2023 09:20
@ademidoff ademidoff requested a review from BupycHuk July 20, 2023 09:21
@ademidoff
Copy link
Member Author

@artemgavrilov The codecov check is disrupting the flow. Can we do something about it?

Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think if we write the code in Go instead of Bash, we don't have enough Bash experts in our team to maintain it

build/scripts/create-tags Outdated Show resolved Hide resolved
build/scripts/create-tags Show resolved Hide resolved
build/scripts/create-tags Outdated Show resolved Hide resolved
@ademidoff ademidoff marked this pull request as draft July 21, 2023 12:54
@artemgavrilov
Copy link
Contributor

@artemgavrilov The codecov check is disrupting the flow. Can we do something about it?

I have an idea, but it's based on non-GA feature in go. In general root of the problem that we run agent tests multiple times on different DB versions and generate one report. So last run wins, because of that we have this flip-flop coverage for agent. In recent go versions were added binary format for coverage reports, and there is a command that can merge multiple reports into one. But for unit tests binary format is not GA option yet.

@ademidoff
Copy link
Member Author

@artemgavrilov The codecov check is disrupting the flow. Can we do something about it?

I have an idea, but it's based on non-GA feature in go. In general root of the problem that we run agent tests multiple times on different DB versions and generate one report. So last run wins, because of that we have this flip-flop coverage for agent. In recent go versions were added binary format for coverage reports, and there is a command that can merge multiple reports into one. But for unit tests binary format is not GA option yet.

Do you think we can use this feature for the tests?

@ademidoff ademidoff requested a review from BupycHuk July 24, 2023 15:21
@ademidoff ademidoff marked this pull request as ready for review July 24, 2023 15:22
@artemgavrilov
Copy link
Contributor

@artemgavrilov The codecov check is disrupting the flow. Can we do something about it?

I have an idea, but it's based on non-GA feature in go. In general root of the problem that we run agent tests multiple times on different DB versions and generate one report. So last run wins, because of that we have this flip-flop coverage for agent. In recent go versions were added binary format for coverage reports, and there is a command that can merge multiple reports into one. But for unit tests binary format is not GA option yet.

Do you think we can use this feature for the tests?

I created ticket for that: https://jira.percona.com/browse/PMM-12365
You can try to solve this problem if you want.

@ademidoff ademidoff merged commit ac9bb81 into main Aug 9, 2023
31 checks passed
@ademidoff ademidoff deleted the PMM-4817-move-git-tags-script-to-pmm branch August 9, 2023 08:19
ademidoff pushed a commit that referenced this pull request Aug 9, 2023
* PMM-4817 move create-tags script to pmm

* PMM-4817 update the notes

* PMM-4817 add more comments

* PMM-4817 add popd before continue

* PMM-4817 use pmm-submodules vs distinct repos

* PMM-4817 clone a specific branch, not main

* PMM-4817 update the description

* PMM-4817 do not delete the directory if it exists

* PMM-4817 popd on push failure
ademidoff pushed a commit that referenced this pull request Aug 9, 2023
* PMM-4817 move create-tags script to pmm

* PMM-4817 update the notes

* PMM-4817 add more comments

* PMM-4817 add popd before continue

* PMM-4817 use pmm-submodules vs distinct repos

* PMM-4817 clone a specific branch, not main

* PMM-4817 update the description

* PMM-4817 do not delete the directory if it exists

* PMM-4817 popd on push failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants