PMM-12151-12273 Explain, table improvements. #2349
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2349 +/- ##
=======================================
Coverage 42.91% 42.91%
=======================================
Files 385 385
Lines 48167 48183 +16
=======================================
+ Hits 20670 20679 +9
- Misses 25557 25566 +9
+ Partials 1940 1938 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Managed failed, but its not because of changes in PR (TestDevContainer/Check) |
JiriCtvrtka
requested review from
a team,
BupycHuk and
artemgavrilov
as code owners
JiriCtvrtka
requested review from
ademidoff and
idoqo
and removed request for
a team
Co-authored-by: Alex Tymchuk <[email protected]>
Co-authored-by: Alex Tymchuk <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
Co-authored-by: Artem Gavrilov <[email protected]>
| q = res.ExplainFingerprint | ||
|
|
||
| s, err := s.qanClient.SchemaByQueryID(ctx, serviceID, queryID) |
There was a problem hiding this comment.
should we merge this endpoint with the previous one to not call qan twice?
There was a problem hiding this comment.
@BupycHuk So in this case you want to merge ExplainFingerprintByQueryID and SchemaByQueryID and return everything in scope of ExplainFingerprintByQueryID?
|
Second endpoint is removed, I will also remove first one if #2349 (comment) |
PMM-334, PMM-12151 Fix proper schema usage when dbname is not included in query itself.
PMM-12273 Fix problem with explain in case of query with comments, formatting etc.
Link to the Feature Build: Percona-Lab/pmm-submodules#3329
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: