PMM-12078 HA phase 3 active active PoC #2247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toria-metrics # Conflicts: # managed/cmd/pmm-managed/main.go # managed/services/agents/vmagent.go
…toria-metrics # Conflicts: # docker-compose.yml # managed/cmd/pmm-managed/main.go # managed/services/supervisord/devcontainer_test.go # managed/services/supervisord/supervisord_test.go # managed/testdata/supervisord.d/pmm-db_enabled.ini
JiriCtvrtka
reviewed
Oct 9, 2023
|
|
||
| for { | ||
| select { | ||
| case event := <-s.nodeCh: |
There was a problem hiding this comment.
Should we check for nil there?
JiriCtvrtka
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12078
Link to the Feature Build: SUBMODULES-3251
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: