fix #1961, first char of a proxyadmin user password must not be a *

[fideloper]

CHANGE DESCRIPTION

Problem:

proxysqladmin generated password might start with a * character, which proxysql does not like. It assumes it's a hashed password if it begins with a *.

See #1961

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

Since it's using the operator/controller paradigm, we simply return an error (following the same convention as already set) if the proxyadmin password starts with a * character. Presumably this will fail a reconciliation, causing it to try again until the password does NOT start with a * character.

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?
• Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are all needed new/changed options added to the Helm Chart?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported PXC version?
• Does the change support oldest and newest supported Kubernetes version?

[it-percona-cla]

All committers have signed the CLA.

[egegunes]

i think we should also take some precaution to prevent having * as first character if passwords are generated by the operator

[egegunes]

i think we should also take some precaution to prevent having * as first character if passwords are generated by the operator

@gkech please create a ticket for this, we shouldn't forget to do it after merging this PR.

[gkech]

prevent having * as first character if passwords are generated by the operator

https://perconadev.atlassian.net/browse/K8SPXC-1568 here we are 👍🏽

[JNKPercona]

Test name	Status
affinity-8-0	passed
auto-tuning-8-0	passed
cross-site-8-0	passed
custom-users-8-0	passed
demand-backup-cloud-8-0	passed
demand-backup-encrypted-with-tls-8-0	passed
demand-backup-8-0	passed
demand-backup-parallel-8-0	passed
haproxy-5-7	passed
haproxy-8-0	passed
init-deploy-5-7	passed
init-deploy-8-0	passed
limits-8-0	passed
monitoring-2-0-8-0	passed
one-pod-5-7	passed
one-pod-8-0	passed
pitr-8-0	passed
pitr-gap-errors-8-0	passed
proxy-protocol-8-0	passed
proxysql-sidecar-res-limits-8-0	passed
pvc-resize-5-7	passed
pvc-resize-8-0	passed
recreate-8-0	passed
restore-to-encrypted-cluster-8-0	passed
scaling-proxysql-8-0	passed
scaling-8-0	passed
scheduled-backup-5-7	passed
scheduled-backup-8-0	passed
security-context-8-0	passed
smart-update1-8-0	passed
smart-update2-8-0	passed
storage-8-0	passed
tls-issue-cert-manager-ref-8-0	passed
tls-issue-cert-manager-8-0	passed
tls-issue-self-8-0	passed
upgrade-consistency-8-0	passed
upgrade-haproxy-5-7	passed
upgrade-haproxy-8-0	passed
upgrade-proxysql-5-7	passed
upgrade-proxysql-8-0	passed
users-5-7	passed
users-8-0	passed
validation-hook-8-0	passed
We run 43 out of 43

commit: 65d44b7
image: perconalab/percona-xtradb-cluster-operator:PR-1962-65d44b77

[gkech]

thanks a lot @fideloper

[fideloper]

thank you all as well!