Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPXC-927: add serviceLabels and serviceAnnotations for PXC #1517

Merged
merged 7 commits into from
Dec 11, 2023
Merged

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Nov 2, 2023

K8SPXC-927 Powered by Pull Request Badge

https://jira.percona.com/browse/K8SPXC-927

DESCRIPTION

Problem:
serviceLabel and serviceAnnotation are available to haproxy and proxysql sections, but not for the pxc.

Solution:
Add serviceLabel and serviceAnnotation fields to the pxc section.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Nov 2, 2023
@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/M 30-99 lines labels Nov 22, 2023
@pooknull pooknull marked this pull request as ready for review November 22, 2023 10:50
inelpandzic
inelpandzic previously approved these changes Nov 24, 2023
pkg/controller/pxc/service_test.go Outdated Show resolved Hide resolved
pkg/pxc/service.go Show resolved Hide resolved
deploy/cr.yaml Show resolved Hide resolved
@pooknull pooknull requested a review from inelpandzic December 7, 2023 08:43
@hors hors added this to the v1.14.0 milestone Dec 7, 2023
@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 failure
demand-backup-cloud-8-0 passed
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 failure
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 passed
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 failure
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 passed
upgrade-haproxy-8-0 passed
upgrade-proxysql-8-0 failure
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 37 out of 37

commit: daa19e1
image: perconalab/percona-xtradb-cluster-operator:PR-1517-daa19e16

@hors hors self-requested a review December 11, 2023 08:37
@hors hors merged commit f293f24 into main Dec 11, 2023
6 checks passed
@hors hors deleted the dev/K8SPXC-927 branch December 11, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants