Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPXC-345: add topologySpreadConstraints #1516

Merged
merged 8 commits into from
Dec 11, 2023
Merged

K8SPXC-345: add topologySpreadConstraints #1516

merged 8 commits into from
Dec 11, 2023

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Nov 2, 2023

K8SPXC-345 Powered by Pull Request Badge

https://jira.percona.com/browse/K8SPXC-345

DESCRIPTION

Problem:
There is no option to set topologySpreadConstraints to operator statefulsets.

Solution:
Add topologySpreadConstraints field to the .spec.pxc, .spec.proxysql, .spec.haproxy and .spec.backup.storages.* sections.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/XXL 1000+ lines label Nov 2, 2023
@pooknull pooknull marked this pull request as draft November 2, 2023 09:43
@pooknull pooknull marked this pull request as ready for review November 21, 2023 18:55
inelpandzic
inelpandzic previously approved these changes Nov 24, 2023
hors
hors previously approved these changes Dec 7, 2023
@hors hors added this to the v1.14.0 milestone Dec 7, 2023
Comment on lines 187 to 189
if tsc.WhenUnsatisfiable == "" {
tsc.WhenUnsatisfiable = corev1.DoNotSchedule
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this as default. Maybe we need to use ScheduleAnyway as default. wdyt @spron-in @hors?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Let's use ScheduleAnyway

@pooknull pooknull dismissed stale reviews from hors and inelpandzic via 8075fae December 11, 2023 13:18
@hors hors requested review from egegunes and inelpandzic December 11, 2023 14:33
@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 failure
demand-backup-cloud-8-0 passed
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 failure
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 passed
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 passed
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 passed
upgrade-haproxy-8-0 passed
upgrade-proxysql-8-0 passed
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 37 out of 37

commit: 47f9e22
image: perconalab/percona-xtradb-cluster-operator:PR-1516-47f9e227

@hors hors self-requested a review December 11, 2023 16:14
@hors hors merged commit f957c53 into main Dec 11, 2023
12 of 13 checks passed
@hors hors deleted the dev/K8SPXC-345 branch December 11, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL 1000+ lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants