Merge branch 'main' into K8SPXC-1079-standardize-service-exposure

percona · Dec 3, 2023 · 68245f7 · 68245f7
2 parents 2662e2d + 6a3f339
commit 68245f7
Show file tree

Hide file tree

Showing 10 changed files with 31 additions and 3 deletions.
diff --git a/.github/workflows/scan.yml b/.github/workflows/scan.yml
@@ -14,7 +14,7 @@ jobs:
           export DOCKER_SQUASH=0
           ./e2e-tests/build
       - name: Run Trivy vulnerability scanner
-        uses: aquasecurity/trivy-action@0.13.1
+        uses: aquasecurity/trivy-action@0.14.0
         with:
           image-ref: 'docker.io/perconalab/percona-xtradb-cluster-operator:${{ github.sha }}'
           format: 'table'

diff --git a/cmd/pitr/collector/collector.go b/cmd/pitr/collector/collector.go
@@ -41,6 +41,7 @@ type Config struct {
 	BufferSize         int64   `env:"BUFFER_SIZE"`
 	CollectSpanSec     float64 `env:"COLLECT_SPAN_SEC" envDefault:"60"`
 	VerifyTLS          bool    `env:"VERIFY_TLS" envDefault:"true"`
+	TimeoutSeconds     float64 `env:"TIMEOUT_SECONDS" envDefault:"60"`
 }
 
 type BackupS3 struct {

diff --git a/cmd/pitr/main.go b/cmd/pitr/main.go
@@ -45,9 +45,12 @@ func runCollector(ctx context.Context) {
 	}
 	log.Println("run binlog collector")
 	for {
-		err := c.Run(ctx)
+		timeout, cancel := context.WithTimeout(ctx, time.Duration(config.CollectSpanSec)*time.Second)
+		defer cancel()
+
+		err := c.Run(timeout)
 		if err != nil {
-			log.Println("ERROR:", err)
+			log.Fatalln("ERROR:", err)
 		}
 
 		t := time.NewTimer(time.Duration(config.CollectSpanSec) * time.Second)

diff --git a/config/crd/bases/pxc.percona.com_perconaxtradbclusters.yaml b/config/crd/bases/pxc.percona.com_perconaxtradbclusters.yaml
@@ -115,6 +115,8 @@ spec:
                         type: string
                       timeBetweenUploads:
                         type: number
+                      timeoutSeconds:
+                        type: number
                     type: object
                   schedule:
                     items:

diff --git a/deploy/bundle.yaml b/deploy/bundle.yaml
@@ -852,6 +852,8 @@ spec:
                         type: string
                       timeBetweenUploads:
                         type: number
+                      timeoutSeconds:
+                        type: number
                     type: object
                   schedule:
                     items:

diff --git a/deploy/cr.yaml b/deploy/cr.yaml
@@ -523,6 +523,7 @@ spec:
       enabled: false
       storageName: STORAGE-NAME-HERE
       timeBetweenUploads: 60
+      timeoutSeconds: 60
 #      resources:
 #        requests:
 #          memory: 0.1G

diff --git a/deploy/crd.yaml b/deploy/crd.yaml
@@ -852,6 +852,8 @@ spec:
                         type: string
                       timeBetweenUploads:
                         type: number
+                      timeoutSeconds:
+                        type: number
                     type: object
                   schedule:
                     items:

diff --git a/deploy/cw-bundle.yaml b/deploy/cw-bundle.yaml
@@ -852,6 +852,8 @@ spec:
                         type: string
                       timeBetweenUploads:
                         type: number
+                      timeoutSeconds:
+                        type: number
                     type: object
                   schedule:
                     items:

diff --git a/pkg/apis/pxc/v1/pxc_types.go b/pkg/apis/pxc/v1/pxc_types.go
@@ -154,6 +154,7 @@ type PITRSpec struct {
 	StorageName        string                      `json:"storageName"`
 	Resources          corev1.ResourceRequirements `json:"resources,omitempty"`
 	TimeBetweenUploads float64                     `json:"timeBetweenUploads,omitempty"`
+	TimeoutSeconds     float64                     `json:"timeoutSeconds,omitempty"`
 }
 
 type PXCScheduledBackupSchedule struct {
@@ -907,6 +908,10 @@ func (cr *PerconaXtraDBCluster) CheckNSetDefaults(serverVersion *version.ServerV
 			if cr.Spec.Backup.PITR.TimeBetweenUploads == 0 {
 				cr.Spec.Backup.PITR.TimeBetweenUploads = 60
 			}
+
+			if cr.Spec.Backup.PITR.TimeoutSeconds == 0 {
+				cr.Spec.Backup.PITR.TimeoutSeconds = 3600
+			}
 		}
 
 		for _, sch := range c.Backup.Schedule {

diff --git a/pkg/pxc/app/deployment/binlog-collector.go b/pkg/pxc/app/deployment/binlog-collector.go
@@ -69,6 +69,16 @@ func GetBinlogCollectorDeployment(cr *api.PerconaXtraDBCluster) (appsv1.Deployme
 			Value: strconv.FormatInt(bufferSize, 10),
 		},
 	}...)
+
+	if cr.CompareVersionWith("1.14.0") >= 0 {
+		timeout := fmt.Sprintf("%.2f", cr.Spec.Backup.PITR.TimeoutSeconds)
+
+		envs = append(envs, corev1.EnvVar{
+			Name:  "TIMEOUT_SECONDS",
+			Value: timeout,
+		})
+	}
+
 	container := corev1.Container{
 		Name:            "pitr",
 		Image:           cr.Spec.Backup.Image,