PT-2377 - fixed pt-table-sync for JSON utf8 strings #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpoettker
force-pushed
the
PT-2377_table_sync_with_utf8_json
branch
from
67e432c
to
e5f0690
Compare
|
I updated the PR such that the change is also included in |
hpoettker
force-pushed
the
PT-2377_table_sync_with_utf8_json
branch
2 times, most recently
from
4acec07
to
fc9987d
Compare
hpoettker
force-pushed
the
PT-2377_table_sync_with_utf8_json
branch
from
fc9987d
to
263404d
Compare
|
I adjusted the added code to also handle The unit test for |
The MySQL driver DBD::mysql does not decode JSON values as utf8 although MySQL uses utf8mb4 for all JSON strings. This change decodes JSON values as utf8 (when not already done) such that SQL statements are generated correctly.
hpoettker
force-pushed
the
PT-2377_table_sync_with_utf8_json
branch
from
263404d
to
ec7705d
Compare
|
Thanks so much for the massive effort to adjust the code base to MySQL 8.4! I've rebased the changes on the latest commit in 3.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is intended to resolve this issue: https://perconadev.atlassian.net/browse/PT-2377
The tests added with
pt-2377.tboth fail with the current code base as they do not generate the expected DML statements with non-ASCII characters correctly. With the proposed change, they run successfully. They test that bothREPLACEandUPDATEstatements are generated correctly bypt-table-syncwhen applied to tables with JSON columns that contain non-ASCII characters.The code is my own creation and it can be distributed under the GPL2 licence.