Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13519: Drop Mongo URI from logs #952

Merged
merged 1 commit into from
Nov 7, 2024
Merged

PMM-13519: Drop Mongo URI from logs #952

merged 1 commit into from
Nov 7, 2024

Conversation

idoqo
Copy link
Contributor

@idoqo idoqo commented Nov 7, 2024

PMM-13519 (optional, if ticket reported)

Closes #950


Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

It also adds basic documentation about the collections in the exporters
and what they do.
@idoqo idoqo requested a review from a team as a code owner November 7, 2024 12:29
@idoqo idoqo requested review from ademidoff and JiriCtvrtka and removed request for a team November 7, 2024 12:29
@idoqo idoqo merged commit 6d48a93 into main Nov 7, 2024
14 checks passed
@idoqo idoqo deleted the drop-uri-from-logs branch November 7, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pbm_collector is logging the mongo URI with user credentials in plain text
3 participants