PMM-11148 Service management - Add/Edit service #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1148-inventory-manage-labels
matejkubinec
changed the title
fabio-silva
requested changes
Jan 26, 2023
public/app/percona/add-instance/components/AddRemoteInstance/FormParts/FormParts.messages.ts
Outdated
Show resolved
Hide resolved
public/app/percona/inventory/ColumnRenderers/ColumnRenderers.tsx
Outdated
Show resolved
Hide resolved
public/app/percona/inventory/components/DeleteServiceModal/DeleteServiceModal.tsx
Outdated
Show resolved
Hide resolved
.../add-instance/components/AddRemoteInstance/FormParts/AdditionalOptions/AdditionalOptions.tsx
Show resolved
Hide resolved
...moteInstance/FormParts/ExternalServiceConnectionDetails/ExternalServiceConnectionDetails.tsx
Show resolved
Hide resolved
public/app/percona/add-instance/components/AddRemoteInstance/FormParts/Labels/Labels.tsx
Show resolved
Hide resolved
fabio-silva
previously approved these changes
Jan 27, 2023
fabio-silva
previously approved these changes
Jun 26, 2023
…1148-inventory-manage-labels
fabio-silva
previously approved these changes
Jul 24, 2023
fabio-silva
previously approved these changes
Aug 16, 2023
…1148-inventory-manage-labels
matejkubinec
requested review from
fabio-silva,
doracretu3pillar and
YashSartanpara1
YashSartanpara1
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds ability to edit standard and custom labels. Visual refresh for add service form and inventory table.
Which issue(s) this PR fixes:
PMM-11148
Screenshots:
FB: Percona-Lab/pmm-submodules#3026