PMM-9403 Fix replication lag panel. #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademidoff
reviewed
Mar 4, 2024
| @@ -378,7 +378,7 @@ | |||
| { | |||
| "datasource": "Metrics", | |||
| "exemplar": false, | |||
| "expr": "avg by (set) (max_over_time(mongodb_mongod_replset_member_replication_lag{set=\"$replset\",state=\"SECONDARY\",service_name=~\"$service_name\"}[${__range}]))", | |||
| "expr": "avg by (set) (max_over_time(mongodb_mongod_replset_member_replication_lag{set=\"$replset\",state=\"SECONDARY\",self=~\"|1\",service_name=~\"$service_name\"}[${__range}]))", | |||
There was a problem hiding this comment.
I have a question: if self can take values of either "" or "1", then would this PR change anything? otherwise, what other values could it take?
There was a problem hiding this comment.
it's made to still show something for old clients which has no value for this label, for new clients it will be "0" or "1" and we should ignore the ones that has "0" as value
ademidoff
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other links:
Percona-Lab/pmm-submodules#3566
percona/mongodb_exporter#804