Skip to content

PMM-1989: fix panic #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

PMM-1989: fix panic #27

wants to merge 8 commits into from

Conversation

arvenil
Copy link
Contributor

@arvenil arvenil commented Feb 15, 2018

This merges #13 and #22

@CLAassistant
Copy link

CLAassistant commented Feb 15, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ rnovikovP
✅ arvenil
❌ fukaya
❌ xuewindy


fukaya seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@arvenil arvenil requested a review from AlekSi February 15, 2018 17:15
@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #27 into master will increase coverage by 13.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
+ Coverage   66.69%   79.79%   +13.1%     
==========================================
  Files           7        7              
  Lines        1375     1376       +1     
==========================================
+ Hits          917     1098     +181     
+ Misses        348      228     -120     
+ Partials      110       50      -60
Impacted Files Coverage Δ
query/query.go 97.2% <100%> (+31.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 251dbc2...9dec0c2. Read the comment docs.

@rnovikovP
Copy link
Contributor

@tfukaya , @xuewindy can you sign our Contributor License Agreement (by clicking the button above) to help us merge your PRs. Thanks for helping us!

@ghost
Copy link

ghost commented Feb 16, 2018

Thanks!
I will confirm my company to agree the CLA.
Please wait a moment.

@arvenil arvenil changed the title PMM-1989 fix panic PMM-1989: fix panic Feb 20, 2018
@ghost
Copy link

ghost commented Feb 23, 2018

@rnovikovP
I just signed the CLA.
Thanks.

@arvenil
Copy link
Contributor Author

arvenil commented May 10, 2018

@xuewindy Could you sign the CLA?

@arvenil arvenil closed this Oct 28, 2018
@ademidoff ademidoff deleted the PMM-1989_fix_panic branch June 27, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants