clarify basic usage #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also helps understand percolatestudio#58
|
Thanks for the PR. Sorry, I didn't notice this pull request earlier. I kept the warning but reverted the changes to the example to maintain consistency with the rest of the docs, which refer back to those lines. If you feel those changes are necessary, lets discuss it further. Cheers. |
|
ok. |
boxofrox
added a commit
to boxofrox/publish-counts
that referenced
this pull request
Dec 15, 2015
I meant to revert all changes to example 1 before merging PR percolatestudio#72 and missed this bit. Fixes percolatestudio#78. Signed-off-by: Justin Charette <[email protected]>
boxofrox
added a commit
to boxofrox/publish-counts
that referenced
this pull request
Dec 15, 2015
I meant to revert all changes to example 1 before merging PR percolatestudio#72 and missed this bit. Fixes percolatestudio#78. Signed-off-by: Justin Charette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with this package was confusing, so here's how I would clarify the tutorial.
also helps understand issue #58