Fixed rescheduling jobs when mongodb timed out during execution of job. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! |
MichalW
reviewed
Dec 14, 2016
| @@ -225,11 +225,11 @@ SyncedCron._entryWrapper = function(entry) { | |||
| } | |||
| }); | |||
| } catch(e) { | |||
| log.info('Exception "' + entry.name +'" ' + e.stack); | |||
| log.info('Exception "' + entry.name +'" ' + ((e && e.stack) ? e.stack : e)); | |||
There was a problem hiding this comment.
It will be better:
log.info('Exception "' + entry.name +'" ' + (e && e.stack || e));
|
this issue is related to #69 |
|
+1 |
|
@Kurounin cool, I was trying to get the whole thing merged. @TheGame2500 do you know if there's a release planned that includes this patch? I have 1.3.0 in production at the moment, which I suppose doesn't include it. |
|
@paolo-g I've been using my fork since I made the PR. The PR was merged 15 days ago. @TheGame2500 will you release a new version on atmospherejs? |
|
@zol bump <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using external mongo db, if it timedout when running a scheduled job or when trying to update a job that has thrown an exception, the job would not be rescheduled to run again.
This fixes that.