Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid error on duplicate define calls #157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid error on duplicate define calls #157

wants to merge 1 commit into from

Conversation

SebastienGllmt
Copy link

This is a fix to solve #156

@yigitguler
Copy link
Contributor

Thanks! we will review it soon.

yasincaliskan
yasincaliskan approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@yasincaliskan yasincaliskan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, it is a good enhancement! 🚀

@SebastienGllmt
Copy link
Author

Any blocker for merging this?

@yigitguler
Copy link
Contributor

We added this to our testing schedule. We will merge it after testing is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasincaliskan yasincaliskan yasincaliskan approved these changes

At least 6 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SebastienGllmt @yigitguler @yasincaliskan