Make draw height precomputed

peppy · Jan 22, 2025 · 222401b · 222401b
1 parent 8002812
commit 222401b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/osu.Game/Screens/SelectV2/BeatmapCarouselFilterGrouping.cs b/osu.Game/Screens/SelectV2/BeatmapCarouselFilterGrouping.cs
@@ -53,6 +53,7 @@ public async Task<IEnumerable<CarouselItem>> Run(IEnumerable<CarouselItem> items
                         newItems.Add(new CarouselItem(b.BeatmapSet!)
                         {
                             IsHeader = true,
+                            DrawHeight = 80,
                             IsGroupSelectionTarget = true
                         });
                     }

diff --git a/osu.Game/Screens/SelectV2/CarouselItem.cs b/osu.Game/Screens/SelectV2/CarouselItem.cs
@@ -11,6 +11,8 @@ namespace osu.Game.Screens.SelectV2
     /// </summary>
     public sealed class CarouselItem : IComparable<CarouselItem>
     {
+        public const float DEFAULT_HEIGHT = 40;
+
         /// <summary>
         /// The model this item is representing.
         /// </summary>
@@ -23,9 +25,9 @@ public sealed class CarouselItem : IComparable<CarouselItem>
         public double CarouselYPosition { get; set; }
 
         /// <summary>
-        /// The height this item will take when displayed.
+        /// The height this item will take when displayed. Defaults to <see cref="DEFAULT_HEIGHT"/>.
         /// </summary>
-        public float DrawHeight => IsHeader ? 80 : 40;
+        public float DrawHeight { get; set; } = DEFAULT_HEIGHT;
 
         /// <summary>
         /// Whether this item is a group header.